Remove RefCell from the definition and some uses of DefMap #29581
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
☔ The latest upstream changes (presumably #29564) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Q: Where is |
|
@bors: r+ |
|
📌 Commit 7123834 has been approved by |
|
oh wait, needs a rebase |
gereeter
force-pushed
the
unwrap-defmap-refcell
branch
from
7123834
to
b1788ef
Compare
|
Rebased. |
|
@bors: r+ |
|
📌 Commit b1788ef has been approved by |
This is basically a more conservative recreation of #24096.
|
💔 Test failed - auto-win-gnu-32-nopt-t |
|
@bors: retry On Wed, Nov 4, 2015 at 9:51 PM, bors notifications@github.com wrote:
|
|
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-msvc-64-opt... |
This is basically a more conservative recreation of #24096.